jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Parvulescu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3742) FileStoreBackup and FileStoreRestore have a reference on Segment Store classes
Date Mon, 14 Dec 2015 10:48:46 GMT

    [ https://issues.apache.org/jira/browse/OAK-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055812#comment-15055812
] 

Alex Parvulescu commented on OAK-3742:
--------------------------------------

to air on the side of safety I would not drop the classes right away, I'd prefer moving them
to a proper package.
the backup and restore functionality has value, it's just the way it was exposed as jmx is
a bit awkward, and the package references go against modularity, so moving them should fix
the problem.
What I would be in favor of is dropping support for backup/restore in oak-run, seeing as a
backup is a plain copy of a repository (taken also online, no need to stop it).

tiny observation on {{oak-run/src/main/java/org/apache/jackrabbit/oak/run/Main.java}}, the
patch changes the imports quite a bit, and I assume this comes from IDE auto imports cleanup
or something. In my view it would be better to not include this in the commit itself.

> FileStoreBackup and FileStoreRestore have a reference on Segment Store classes
> ------------------------------------------------------------------------------
>
>                 Key: OAK-3742
>                 URL: https://issues.apache.org/jira/browse/OAK-3742
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>             Fix For: 1.4
>
>         Attachments: OAK-3742-01.patch
>
>
> {{FileStoreBackup}} and {{FileStoreRestore}} reference classes for the Segment Store
packages to create and initialise a store for backup and restore. This direct reference makes
difficult to move the Segment Store into its own independent bundle.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message