jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vikas Saurabh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-4066) Suggestion dictionary don't update after suggestUpdateFrequencyMinutes unless something else causes index update
Date Mon, 29 Feb 2016 18:14:18 GMT

    [ https://issues.apache.org/jira/browse/OAK-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172279#comment-15172279
] 

Vikas Saurabh commented on OAK-4066:
------------------------------------

Fixed in trunk at [r1732923|http://svn.apache.org/r1732923]. Note, the test case requires
changes done in revision  [r1732647|http://svn.apache.org/r1732647] and [r1732648|http://svn.apache.org/r1732648].

[~chetanm], to avoid redundant runs, I had to resort to comparison of {{lastUpdated}} for
index and that of suggestions. The issue with {{indexedNodes}} was that during a cycle where
index was updated along with suggestions, next suggestions cycle could do a redundant re-build.
Even for using {{lastUpdated}}, I had to refactor a bit to keep same value on both ends.

bq. Given there's always a bit of Oak commits (even not Lucene index related) happening anyway
in real life scenarios, that should be enough to avoid the problem with suggest index not
being updated for long times.
Opened OAK-4075 anyway to track this.

> Suggestion dictionary don't update after suggestUpdateFrequencyMinutes unless something
else causes index update
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: OAK-4066
>                 URL: https://issues.apache.org/jira/browse/OAK-4066
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: lucene
>    Affects Versions: 1.3.16
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>            Priority: Blocker
>             Fix For: 1.4.0
>
>         Attachments: OAK-4066.patch
>
>
> Currently, suggestions building is tied at the end of indexing cycle. Along with that
we check if diff between currTime and lastSugguestionBuildTime is more than {{suggestUpdateFrequencyMinutes}}
before deciding to build suggestions or not.
> This allows for suggestions not getting updated if:
> * At T1 suggestions are built
> * At T2 an index update takes place but suggestions aren't rebuilt because not enough
time has passed since T1
> * Now at T3 (after sufficient time), changes at T2 won't show up for suggestions until
some other index change happens.
> We should probably see track about last changes in index (at T2) and use that too while
running indexing cycle at T3.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message