jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Updated] (OAK-4255) CLONE - FileStore.containsSegment returns alway true (almost)
Date Wed, 20 Apr 2016 12:34:25 GMT

     [ https://issues.apache.org/jira/browse/OAK-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Dürig updated OAK-4255:
-------------------------------
    Component/s:     (was: segmentmk)
                 segment-next

> CLONE - FileStore.containsSegment returns alway true (almost)
> -------------------------------------------------------------
>
>                 Key: OAK-4255
>                 URL: https://issues.apache.org/jira/browse/OAK-4255
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-next
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>            Priority: Critical
>              Labels: compaction, gc, stability
>             Fix For: 1.6
>
>
> {{FileStore.containsSegment()}} looks [funky|https://github.com/mduerig/jackrabbit-oak/blob/36cb3bf6e5078e3afa75581fb789eeca7b5df2e2/oak-segment/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/FileStore.java#L1197-L1197].
This "optimisation" causes it to always return {{true}}. 
> {{containsSegment}} is used for deduplication and revision gc. The current implementation
causes {{SNFE}} exceptions once gc is effective (as I experienced while working on OAK-3348).




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message