jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Updated] (OAK-4106) Reclaimed size reported by FileStore.cleanup is off
Date Wed, 10 Aug 2016 09:08:20 GMT

     [ https://issues.apache.org/jira/browse/OAK-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Dürig updated OAK-4106:
-------------------------------
    Attachment: OAK-4106-02.patch

bq. Another thing that needed modification was the place in which initialSize is computed.

Good catch! I missed that one.

Attaching a slightly edited patch: [^OAK-4106-02.patch]. I think the calculation of {{afterCleanupSize}}
can be simplified. [~dulceanu], please cross check.
I also modified the log statement adding the "TarMK GC #{}:" prefix. 

> Reclaimed size reported by FileStore.cleanup is off
> ---------------------------------------------------
>
>                 Key: OAK-4106
>                 URL: https://issues.apache.org/jira/browse/OAK-4106
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>              Labels: cleanup, gc
>             Fix For: Segment Tar 0.0.10
>
>         Attachments: OAK-4106-01.patch, OAK-4106-02.patch
>
>
> The current implementation simply reports the difference between the repository size
before cleanup to the size after cleanup. As cleanup runs concurrently to other commits, the
size increase contributed by those is not accounted for. In the extreme case where cleanup
cannot reclaim anything this can even result in negative values being reported. 
> We should either change the wording of the respective log message and speak of before
and after sizes or adjust our calculation of reclaimed size (preferred). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message