jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrei Dulceanu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-4106) Reclaimed size reported by FileStore.cleanup is off
Date Wed, 10 Aug 2016 09:24:20 GMT

    [ https://issues.apache.org/jira/browse/OAK-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415007#comment-15415007
] 

Andrei Dulceanu commented on OAK-4106:
--------------------------------------

[~mduerig] Everything ok from my side. One improvement which would improve code readability
is replacing {{newReader}} with {{sweptReader}} in the for loop which computes {{afterCleanupSize}}.
This would allow also to remove the comment introduced by me regarding the difference between
{{newReader}} and {{reader}}. If you think it's worth it I can provide the new patch, if not,
please go ahead and apply yours. Thank you!

> Reclaimed size reported by FileStore.cleanup is off
> ---------------------------------------------------
>
>                 Key: OAK-4106
>                 URL: https://issues.apache.org/jira/browse/OAK-4106
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>              Labels: cleanup, gc
>             Fix For: Segment Tar 0.0.10
>
>         Attachments: OAK-4106-01.patch, OAK-4106-02.patch
>
>
> The current implementation simply reports the difference between the repository size
before cleanup to the size after cleanup. As cleanup runs concurrently to other commits, the
size increase contributed by those is not accounted for. In the extreme case where cleanup
cannot reclaim anything this can even result in negative values being reported. 
> We should either change the wording of the respective log message and speak of before
and after sizes or adjust our calculation of reclaimed size (preferred). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message