jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Reutegger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-4623) Log more information when null DocumentNodeState is read for a child while fetching children
Date Mon, 22 Aug 2016 07:08:20 GMT

    [ https://issues.apache.org/jira/browse/OAK-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430214#comment-15430214
] 

Marcel Reutegger commented on OAK-4623:
---------------------------------------

The extra log will indeed only happen in rare cases. I think it is fine to read
uncached in this case. The patch looks good to me. Just one minor typo. The doc
logging starts with a curly bracket and ends with a regular one.

> Log more information when null DocumentNodeState is read for a child while fetching children
> --------------------------------------------------------------------------------------------
>
>                 Key: OAK-4623
>                 URL: https://issues.apache.org/jira/browse/OAK-4623
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: documentmk
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>            Priority: Minor
>             Fix For: 1.6
>
>
> {{DocumentNodeStore#getChildNodes}} validates node states of children in the returned
iterator and throws exception if a child is read as {{null}}.
> This is clearly an unexpected case (although, it has been observed in running systems).
The more probable cause for such a scenario would be to have inconsistent value in {{nodeChildrenCache}}.
It'd be useful to log more information about cache state to help investigating such cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message