jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arek Kita (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OAK-4630) Create segment tar directory only when it's missing
Date Tue, 02 Aug 2016 10:34:20 GMT

     [ https://issues.apache.org/jira/browse/OAK-4630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Arek Kita updated OAK-4630:
---------------------------
    Attachment: OAK-4630-create-segment-tar-directory-only-when-it-is-missing.patch

I'm attaching a patch file with the proposed fix only for {{SegmentTar}} node store. I've
updated one test converts tar node store into segment tar node store to not create directory
explicitly. In other test cases the directory is still created to cover both cases without
creating explicit tests for that.

> Create segment tar directory only when it's missing
> ---------------------------------------------------
>
>                 Key: OAK-4630
>                 URL: https://issues.apache.org/jira/browse/OAK-4630
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar, upgrade
>            Reporter: Arek Kita
>            Priority: Minor
>              Labels: patch
>         Attachments: OAK-4630-create-segment-tar-directory-only-when-it-is-missing.patch
>
>
> Currently using oak-upgrade we are dealing with source directory which should naturally
exist and destination directory which in most of the cases (especially for segment-tar) does
not exist at all.
> It's awkward to demand from oak-upgrade caller to always create such directory as the
upgrade process should create everything it needs and it can simply do this on its own in
majority of simple cases. 
> In some sophisticated cases user should be able to create that directory on her/his own
and mount i.e. external filesystem to it before using {{oak-upgrade}} but that's very special
case that still should work out of the box. In that case we should never demand that the path
cannot exist. It should work in both cases whether directory is created or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message