jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arek Kita (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OAK-4630) Create segment and segment tar directory only when it's missing
Date Tue, 02 Aug 2016 12:04:20 GMT

    [ https://issues.apache.org/jira/browse/OAK-4630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403855#comment-15403855
] 

Arek Kita edited comment on OAK-4630 at 8/2/16 12:04 PM:
---------------------------------------------------------

I've updated the patch and added the same improvement for *old segment* node store to be consistent
with new segment tar and I've added dedicated tests for missing directories for both node
store implementations.


was (Author: arkadius):
I've updated the patch and added the same improvement for *old segmen* node store to be consistent
with new segment tar and I've added dedicated tests for missing directories for both node
store implementations.

> Create segment and segment tar directory only when it's missing
> ---------------------------------------------------------------
>
>                 Key: OAK-4630
>                 URL: https://issues.apache.org/jira/browse/OAK-4630
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: upgrade
>            Reporter: Arek Kita
>            Priority: Minor
>              Labels: patch
>             Fix For: 1.6
>
>         Attachments: OAK-4630-create-segment-tar-directory-only-when-it-is-missing.patch
>
>
> Currently using oak-upgrade we are dealing with source directory which should naturally
exist and destination directory which in most of the cases (especially for segment-tar) does
not exist at all.
> It's awkward to demand from oak-upgrade caller to always create such directory as the
upgrade process should create everything it needs and it can simply do this on its own in
majority of simple cases. 
> In some sophisticated cases user should be able to create that directory on her/his own
and mount i.e. external filesystem to it before using {{oak-upgrade}} but that's very special
case that still should work out of the box. In that case we should never demand that the path
cannot exist. It should work in both cases whether directory is created or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message