jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Resolved] (OAK-4287) Disable / remove SegmentBufferWriter#checkGCGen
Date Thu, 15 Sep 2016 10:24:20 GMT

     [ https://issues.apache.org/jira/browse/OAK-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Michael Dürig resolved OAK-4287.
    Resolution: Fixed

Fixed at http://svn.apache.org/viewvc?rev=1760914&view=rev

Turns out that OAK-4631 removed the check already. I added it back but disabled it by default.
It can be enabled with {{-Denable-generation-check=true}}.

cc [~volteanu]

> Disable / remove SegmentBufferWriter#checkGCGen
> -----------------------------------------------
>                 Key: OAK-4287
>                 URL: https://issues.apache.org/jira/browse/OAK-4287
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: assertion, compaction, gc
>             Fix For: Segment Tar 0.0.12
> {{SegmentBufferWriter#checkGCGen}} is an after the fact check for back references (see
OAK-3348), logging a warning if detects any. As this check loads the segment it checks the
reference for, it is somewhat expensive. We should either come up with a cheaper way for this
check or remove it (at least disable it by default). 

This message was sent by Atlassian JIRA

View raw message