jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OAK-4793) Check usage of DocumentStoreException in RDBDocumentStore
Date Tue, 13 Sep 2016 13:15:20 GMT

    [ https://issues.apache.org/jira/browse/OAK-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487160#comment-15487160
] 

Julian Reschke edited comment on OAK-4793 at 9/13/16 1:14 PM:
--------------------------------------------------------------

Proposed change.

Note that RDBDocumentStore doesn't use auto-commits, thus a SQLException in a call other than
commit() will trigger a rollback anyway.

The test cases injects SQLExceptions after commits (after calling the actual commit, but before
returning to DocumentStore) and observes cache correctness.

We have to check whether the assumptions above are correct, and whether the test covers all
relevant method signatures.


was (Author: reschke):
Proposed change.

Note that with RDBDocumentStore's doesn't use auto-commits, thus a SQLException in a call
other than commit() will trigger a rollback anyway.

The test cases injects SQLExceptions after commits (after calling the actual commit, but before
returning to DocumentStore) and observes cache correctness.

We have to check whether the assumptions above are correct, and whether the test covers all
relevant method signatures.

> Check usage of DocumentStoreException in RDBDocumentStore
> ---------------------------------------------------------
>
>                 Key: OAK-4793
>                 URL: https://issues.apache.org/jira/browse/OAK-4793
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: core, rdbmk
>            Reporter: Marcel Reutegger
>            Assignee: Julian Reschke
>            Priority: Minor
>             Fix For: 1.6
>
>         Attachments: OAK-4793.diff, OAK-4793.diff
>
>
> With OAK-4771 the usage of DocumentStoreException was clarified in the DocumentStore
interface. The purpose of this task is to check usage of the DocumentStoreException in RDBDocumentStore
and make sure JDBC driver specific exceptions are handled consistently and wrapped in a DocumentStoreException.
At the same time, cache consistency needs to be checked as well in case of a driver exception.
E.g. invalidate if necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message