jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrei Dulceanu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-4803) Simplify the client side of the cold standby
Date Thu, 15 Sep 2016 12:07:20 GMT

    [ https://issues.apache.org/jira/browse/OAK-4803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493120#comment-15493120
] 

Andrei Dulceanu commented on OAK-4803:
--------------------------------------

[~frm], I guess you're right with the separation of concerns pointed out for my 1st suggestion.
bq. Is this maybe the scope of another improvement issue?
Maybe it makes sense to move this to another issue, since this issue already handles quite
a number of aspects.
bq. I quite don't agree here. You need a client to perform a sync.
Reading the whole explanation, I think it's a valid point of view so I will adhere to it :)

> Simplify the client side of the cold standby
> --------------------------------------------
>
>                 Key: OAK-4803
>                 URL: https://issues.apache.org/jira/browse/OAK-4803
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>             Fix For: Segment Tar 0.0.12
>
>         Attachments: OAK-4803-01.patch
>
>
> The implementation of the cold standby client is overly and unnecessarily complicated.
It would be way clearer to separate the client code in two major components: a simple client
responsible for sending messages to and receive responses from the standby server, and the
synchronization algorithm used to read data from the server and to save read data in the local
{{FileStore}}.
> Moreover, the client simple client could be further modularised by encapsulating request
encoding, response decoding and message handling into their own Netty handlers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message