jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Comment Edited] (OAK-5055) o.a.j.o.s.s.RevisionGC returns status that don't comply with the API
Date Thu, 03 Nov 2016 16:15:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633290#comment-15633290
] 

Michael Dürig edited comment on OAK-5055 at 11/3/16 4:14 PM:
-------------------------------------------------------------

I like this approach. As a small improvement I think we should bass the management operation
to e.g. {{initiated}} instead of just the id. 

I will rework the patch to that respect and apply. Unless you have objections. 


was (Author: mduerig):
I like this approach. As a small improvement I think we should bass the management operation
to e.g. {{initiated}} instead of just the id. 

> o.a.j.o.s.s.RevisionGC returns status that don't comply with the API
> --------------------------------------------------------------------
>
>                 Key: OAK-5055
>                 URL: https://issues.apache.org/jira/browse/OAK-5055
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.5.12
>            Reporter: Timothee Maret
>            Assignee: Timothee Maret
>             Fix For: 1.5.13
>
>         Attachments: OAK-5055.patch, OAK-5055.patch, OAK-5055.patch
>
>
> According to the API [0], the method {{RevisionGC#startRevisionGC}} should 
> {code}
> @return  the status of the operation right after it was initiated
> {code} 
> However, it does return {{succeeded}} on every call, see [1].
> I believe this should either compute the actual state, or return {{initiated}} or {{running}}.
> Same applies for {{cancelRevisionGC}}.
> [0] https://github.com/apache/jackrabbit-oak/blob/18d69e6f590064585414f12bda724f48f3d5843f/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGCMBean.java#L34-L40
> [1] https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L105
> https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L123



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message