jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vikas Saurabh (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OAK-4400) Correlate index with the index definition used to build it
Date Wed, 07 Dec 2016 08:11:58 GMT

    [ https://issues.apache.org/jira/browse/OAK-4400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728080#comment-15728080
] 

Vikas Saurabh edited comment on OAK-4400 at 12/7/16 8:11 AM:
-------------------------------------------------------------

diff3 lgtm. There's a little nit-pick that kind of took me off-guard (hoping I read the patch
right). As far the implementation goes, in these 2 cases:
# in absence of {{:index-definition}}
# even when feature flag is off

I'm generally +1 on both the cases, but they seemed to be not-so-explicitly obvious. May be
we should explicitly call out that storing of index def would happen according to rules (reindex/absent-hidden-def/refresh-flag).
Feature flag only control how {{IndexDefinition}} is build for indexing/querying.


was (Author: catholicon):
diff3 lgtm. There's a little nit-pick that kind of took me off-guard (hoping I read the patch
right). As far the implementation goes, in these 2 cases:
# in absence of {{:index-definition}}
# even when feature flag is off
I'm generally +1 on both the cases, but they seemed to be not-so-explicitly obvious. May be
we should explicitly call out that storing of index def would happen according to rules (reindex/absent-hidden-def/refresh-flag).
Feature flag only control how {{IndexDefinition}} is build for indexing/querying.

> Correlate index with the index definition used to build it
> ----------------------------------------------------------
>
>                 Key: OAK-4400
>                 URL: https://issues.apache.org/jira/browse/OAK-4400
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: lucene, query
>    Affects Versions: 1.4
>            Reporter: Valentin Olteanu
>            Assignee: Chetan Mehrotra
>             Fix For: 1.6
>
>         Attachments: OAK-4400-v1.diff, OAK-4400-v2.diff, OAK-4400-v3.diff, lucene-mbean.png
>
>
> Currently, if the definition of an index is changed without reindexing, it will get in
an "inconsistent" state. 
> Of course, the reindexing is usually necessary, but it would be useful to know with which
definition the index was built. This could increase the visibility of the indexing state and
help debugging issues related to it.
> Some questions this improvement should respond to:
> # What is the definition of the index when the (re)indexing was triggered?
> # Are there any changes in the definition since the trigger? Which?
> I can imagine a solution built by "versioning" the definition nodes (oak:QueryIndexDefinition).
When the reindex is triggered, a new version of the node is created and the indexer stores
a reference to it.
> This would also allow the indexer to keep using the same definition until a new reindex,
even if changes are made meanwhile (i.e. use a fixed version instead of the latest definition).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message