jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Parvulescu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-5223) SegmentNodeStoreService components don't unregister with the blobstore
Date Mon, 05 Dec 2016 15:33:58 GMT

    [ https://issues.apache.org/jira/browse/OAK-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15722550#comment-15722550
] 

Alex Parvulescu commented on OAK-5223:
--------------------------------------

patch looks good! the only aspect we need to clarify is _if_ we can have concurrent calls
to _unregisterNodeStore_  and _ registerNodeStore_ (which would mean the fileStore would {{close}}
and {{init}} concurrently on the same path) caused by the blobStore component. it's unlikely
that this is the case, but to be on the safe side, I mention it anyway.

bq. The most immediate improvement of this code would be to encapsulate every unregister,
stop and close method into its own Closeable, and delegate the cleanup to a com.google.common.io.Closer
to make sure that every resource is released properly even in case of error.
good point, let's do that as a part of OAK-5224

> SegmentNodeStoreService components don't unregister with the blobstore
> ----------------------------------------------------------------------
>
>                 Key: OAK-5223
>                 URL: https://issues.apache.org/jira/browse/OAK-5223
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>             Fix For: 1.6, 1.5.15
>
>         Attachments: OAK-5223-02.patch, OAK-5223.patch
>
>
> There are a few components in the SegmentNodeStoreService ({{store}}, {{segmentNodeStore}},
{{gcMonitor}} and {{observerTracker}}) that aren't unregistered when the blobStore unregisters.
So in the case of a blobStore unregister/register situation, they will be recreated but the
old ones will not be closed properly.
> [edit] added all components that have a leak problem when the blob store binds/unbinds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message