jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Parvulescu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-5223) SegmentNodeStoreService components don't unregister with the blobstore
Date Tue, 06 Dec 2016 14:33:58 GMT

    [ https://issues.apache.org/jira/browse/OAK-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725670#comment-15725670
] 

Alex Parvulescu commented on OAK-5223:
--------------------------------------

bq. I had to change a couple of tests in oak-core and oak-segment-tar.
{noformat}
     @Test
     public void registerBlobTrackingStore() throws Exception {
+        registerTrackingBlobStore();
         registerNodeStoreService();
-        assertServiceNotActivated();
-        registerTrackingBlobStore();
         assertServiceActivated();
{noformat}
If I'm not mistaken, even with the new reference binding option, this is still a case we need
to support (blobstore coming online after the nodestore). this change looks dangerous to me,
even if it's a OSGi Mocks-related problem, removing the current test means we're at zero coverage
for this scenario (same applies to {SegmentNodeStoreServiceTest}}). what other options do
we have?

> SegmentNodeStoreService components don't unregister with the blobstore
> ----------------------------------------------------------------------
>
>                 Key: OAK-5223
>                 URL: https://issues.apache.org/jira/browse/OAK-5223
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>             Fix For: 1.6, 1.5.15
>
>         Attachments: OAK-5223-02.patch, OAK-5223-03.patch, OAK-5223-04.patch, OAK-5223.patch
>
>
> There are a few components in the SegmentNodeStoreService ({{store}}, {{segmentNodeStore}},
{{gcMonitor}} and {{observerTracker}}) that aren't unregistered when the blobStore unregisters.
So in the case of a blobStore unregister/register situation, they will be recreated but the
old ones will not be closed properly.
> [edit] added all components that have a leak problem when the blob store binds/unbinds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message