jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-5335) Clarify the various directories and their usages in SegmentNodeStoreService
Date Tue, 20 Dec 2016 17:05:58 GMT

    [ https://issues.apache.org/jira/browse/OAK-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764686#comment-15764686

Michael Dürig commented on OAK-5335:

My main issue here is the removal of {{getBaseDirectory()}}. That method defaulted to {{tarmk}},
the patch changes the default to {{repository}}. Isn't there a potential for regressions?
Maybe not as there are no prior installations of Segment Tar, but we should still consider
the question and investigate who put those methods there and why. 

Then I would like further alignment in the naming around {{getRootDirectory()}}. {{getRootDirectory()}}
returns "repository" as default, it uses the constant {{DIRECTORY}} whose value is {{repository.home}}.
That is four different identifiers for mostly the same thing. 

Finally lets also add some Javadoc while we are researching this. 

> Clarify the various directories and their usages in SegmentNodeStoreService
> ---------------------------------------------------------------------------
>                 Key: OAK-5335
>                 URL: https://issues.apache.org/jira/browse/OAK-5335
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Andrei Dulceanu
>              Labels: technical_debt
>             Fix For: 1.6
>         Attachments: OAK-5335-01.patch
> In {{SegmentNodeStoreService}} there is {{repository.home}}, {{DIRECTORY}}, {{getRootDirectory()}},
{{getDirectory()}} and {{getBaseDirectory()}} mostly without documentation about their intention.
I think we should clarify, document and consolidate them. 

This message was sent by Atlassian JIRA

View raw message