[ https://issues.apache.org/jira/browse/OAK-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764606#comment-15764606
]
Michael Dürig commented on OAK-5355:
------------------------------------
[~anchela], this is the follow up to OAK-5296, which turned out to be not a problem. Still
I think we should improve this so I filed this issue here.
> Too eager refreshing of tree permissions in SecureNodeBuilder
> -------------------------------------------------------------
>
> Key: OAK-5355
> URL: https://issues.apache.org/jira/browse/OAK-5355
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Michael Dürig
> Labels: technical_debt
> Fix For: 1.8
>
>
> {{SecureNodeBuilder.baseChanged()}} calls {{SecureNodeBuilder.getTreePermission()}} even
though the tree permission would be calculated lazily as needed anyway. Re-calculating the
tree permissions at this point bears the risk of accessing stale data from the underlying
not yet fully refreshed root (when being called e.g. from {{MutableRoot.refresh()}}.
> I would thus argue for removing the call to {{SecureNodeBuilder.getTreePermission()}}
from {{SecureNodeBuilder.baseChanged()}}.
> See also OAK-5296 for an in-depth analysis.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
|