jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-5355) Too eager refreshing of tree permissions in SecureNodeBuilder
Date Wed, 21 Dec 2016 10:53:58 GMT

    [ https://issues.apache.org/jira/browse/OAK-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766745#comment-15766745

angela commented on OAK-5355:

agreed... let me take another look and try to find a decent test-coverage to minimize the
regression risk.

> Too eager refreshing of tree permissions in SecureNodeBuilder
> -------------------------------------------------------------
>                 Key: OAK-5355
>                 URL: https://issues.apache.org/jira/browse/OAK-5355
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Michael Dürig
>            Assignee: angela
>              Labels: technical_debt
>             Fix For: 1.8
> {{SecureNodeBuilder.baseChanged()}} calls {{SecureNodeBuilder.getTreePermission()}} even
though the tree permission would be calculated lazily as needed anyway. Re-calculating the
tree permissions at this point bears the risk of accessing stale data from the underlying
not yet fully refreshed root (when being called e.g. from {{MutableRoot.refresh()}}. 
> I would thus argue for removing the call to {{SecureNodeBuilder.getTreePermission()}}
from {{SecureNodeBuilder.baseChanged()}}. 
> See also OAK-5296 for an in-depth analysis. 

This message was sent by Atlassian JIRA

View raw message