jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomek Rękawek (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-6481) Missing versionable path property for oak:mount-libs-crx.default
Date Fri, 21 Jul 2017 12:11:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096175#comment-16096175
] 

Tomek Rękawek commented on OAK-6481:
------------------------------------

Attached a [patch proposal|^OAK-6481.patch] that passes the workspace name and the mount separately,
so the permission store code can get the permission root properly, without losing the original
workspace name (which can be used in other Oak methods).

If no multiplexing is used, the default Mount is passed, which fall backs to the default behaviour:
{code}
    public static @Nonnull String getPermissionRootName(@Nonnull Mount mount, @Nonnull String
workspace) {
        if (mount.isDefault()) {
            return workspace;
        } else {
            return mount.getPathFragmentName() + "-" + workspace;
        }
    }
{code}

[~anchela], [~stillalex], WDYT?

> Missing versionable path property for oak:mount-libs-crx.default
> ----------------------------------------------------------------
>
>                 Key: OAK-6481
>                 URL: https://issues.apache.org/jira/browse/OAK-6481
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.7.3
>            Reporter: Tomek Rękawek
>             Fix For: 1.8
>
>         Attachments: OAK-6481.patch
>
>
> After applying the OAK-3777, following warning can be found in the logs:
> {noformat}
> 21.07.2017 02:00:00.713 *WARN* [sling-default-999-HourlySnapshotJob] org.apache.jackrabbit.oak.plugins.version.ReadOnlyVersionManager
Missing versionable path property for oak:mount-libs-crx.default at /jcr:system/jcr:versionStorage/5e/8d/89/5e8d8989-f86b-4e1b-b7f8-5089c44f5ed7
> 21.07.2017 02:00:00.713 *WARN* [sling-default-999-HourlySnapshotJob] org.apache.jackrabbit.oak.security.authorization.permission.CompiledPermissionImpl
Cannot retrieve versionable node for /jcr:system/jcr:versionStorage/5e/8d/89/5e8d8989-f86b-4e1b-b7f8-5089c44f5ed7/1.0/jcr:frozenNode
> {noformat}
> It suggests that somehow the name of the new permission store (oak:mount-libs-crx.default)
is being used as the workspace name for the version storage.
> If I understand correctly, it shouldn't happen. The workspace name is sometimes used
as the name of the permission store node (eg. {{/jcr:system/rep:permissionStore/crx.default}}),
but not the other way around - the name of the permission store node is not always a valid
workspace name (eg. {{/jcr:system/rep:permissionStore/oak:mount-libs-crx.default}})
> //cc: [~stillalex]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message