jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-6318) Refactor oak.spi.security into a separate module/bundle
Date Wed, 13 Sep 2017 06:56:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164228#comment-16164228
] 

angela commented on OAK-6318:
-----------------------------

[~stillalex], now that the spi-query parts have been moved out of oak-core i see the following
next steps
- moving the {{spi.xml}} out of oak-core as you propose
- {{ConfigurationUtil}} is definitely misplaced in the spi package... maybe moving to the
tests or to _o.a.j.oak.security_?
- regarding the string constants: i don't know what would be the best approach here.... but
i found that moving out _plugins.document_ out of oak-core will face the same issue. maybe
introducing new constants somewhere in the _spi_ package space and have once in _plugins.*_
extend from those?

> Refactor oak.spi.security into a separate module/bundle
> -------------------------------------------------------
>
>                 Key: OAK-6318
>                 URL: https://issues.apache.org/jira/browse/OAK-6318
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core, security
>            Reporter: angela
>
> In the light of the modularization effort it would IMHO make a lot of sense to refactor
_oak.spi.security.*_ into a separate module/bundle that could be release independent of _oak-core_.
> As far as I could see so far this is currently not easily doable due to the dependency
of {{oak.spi.security.*}} on {{oak.plugins.tree}}, which in turn relies on {{o.a.j.oak.query.QueryEngineSettings}}
and other oak-core internals (see also OAK-6304). Most likely this issue would therefore require
a complete review (and possibly a split) of  the {{oak.plugins.tree}} package space which
contains a mixture of utilities and 'API' (like e.g. {{TreeContext}} and {{TreeLocation}})...
will open a separate issue for this linking to this one.
> cc: [~alex.parvulescu], [~rombert], [~mduerig], [~tmueller]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message