jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vikas Saurabh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-6895) Suggest directory lookup (query) isn't closed
Date Thu, 02 Nov 2017 02:17:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235084#comment-16235084
] 

Vikas Saurabh commented on OAK-6895:
------------------------------------

This
{noformat}
diff --git a/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/reader/DefaultIndexReader.java
b/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/reader/DefaultIndexReader.java
index e571c2d5a0..b0e6c8ca6a 100644
--- a/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/reader/DefaultIndexReader.java
+++ b/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/reader/DefaultIndexReader.java
@@ -77,6 +77,9 @@ public class DefaultIndexReader implements LuceneIndexReader {
         try {
             reader.close();
         } finally {
+            if (suggestDirectory != null) {
+                suggestDirectory.close();
+            }
             directory.close();
         }
     }
{noformat}
seems to be reasonable solution (tests a bit later). [~chetanm], this would highly require
your inputs :).

> Suggest directory lookup (query) isn't closed
> ---------------------------------------------
>
>                 Key: OAK-6895
>                 URL: https://issues.apache.org/jira/browse/OAK-6895
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: lucene
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>            Priority: Major
>             Fix For: 1.8
>
>
> After OAK-6775, it was observed that we are leaking file handles pointing to suggestion
directory files.
> This is because {{DefaultIndexReader}} doesn't close suggest directory on close.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message