jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chetan Mehrotra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-6917) Configuration presets for DocumentNodeStoreService
Date Thu, 23 Nov 2017 11:41:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-6917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264221#comment-16264221
] 

Chetan Mehrotra commented on OAK-6917:
--------------------------------------

Abstracting out config logic was long overdue! So good we have it now

Looking at the patch it uses Preset class. This class does not have config policy required
so it can happen (mostly theoretical) that this component gets activated without config and
then DNSS get activated (as Preset reference becomes satisfied). Now later the config gets
delivered by ConfigurationAdmin and this component gets reactivated thus causing DNSS to get
reactivated. 

Given DocumentNodeStoreServiceConfiguration is already using ConfigAdmin may be we use it
to fetch config for preset also and thus avoid all this dummy reference

PS: I am not sure how SCR and ConfigAdmin interact for component where config policy is not
required. Would it ensure that if config is already present in config admin then it uses that
always for first activation post start

> Configuration presets for DocumentNodeStoreService
> --------------------------------------------------
>
>                 Key: OAK-6917
>                 URL: https://issues.apache.org/jira/browse/OAK-6917
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: documentmk
>            Reporter: Marcel Reutegger
>            Assignee: Marcel Reutegger
>            Priority: Minor
>             Fix For: 1.8
>
>         Attachments: OAK-6917-alternative-approach.patch, OAK-6917.patch, OAK-6917.patch
>
>
> When Oak is deployed in an OSGi container, applications usually want to ship a default
configuration which is different from the defaults present in Oak. E.g. an application may
want to use a default cache size of 1G for the DocumentNodeStoreService instead of the default
256M. Now if a user of the application provides a custom configuration and does not specify
the cache size, the value for this configuration will flip back to the Oak default of 256M.
> There should be a way to configure presets for the application that are different from
the Oak defaults and then allow a user to customize the configuration while still respecting
the presets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message