jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Reopened] (OAK-7031) DeleteOnCloseFileInputStream should properly handle errors when deleting the file
Date Tue, 05 Dec 2017 16:10:01 GMT

     [ https://issues.apache.org/jira/browse/OAK-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Dürig reopened OAK-7031:
--------------------------------

Reopening as I think this introduced (surfaced?) a problem on Windows:

{noformat}
Error Message

C:\Windows\TEMP\blobId.tmp: The process cannot access the file because it is being used by
another process.

Stacktrace

java.nio.file.FileSystemException: 
C:\Windows\TEMP\blobId.tmp: The process cannot access the file because it is being used by
another process.

	at org.apache.jackrabbit.oak.segment.standby.codec.ResponseDecoderTest.shouldDecodeValidOneChunkGetBlobResponses(ResponseDecoderTest.java:71)

Standard Output

14:31:24.793 DEBUG [main] ResponseDecoder.java:90           Decoding 'get blob' response
14:31:24.793 DEBUG [main] ResponseDecoder.java:143          Detected previous incomplete transfer
for blobId. Cleaning up...
14:31:24.793 DEBUG [main] ResponseDecoder.java:150          Received chunk 1/1 of size 3 from
blob blobId
14:31:24.793 DEBUG [main] ResponseDecoder.java:159          All checks OK. Appending chunk
to disk to C:\Windows\TEMP\blobId.tmp 
14:31:24.793 DEBUG [main] ResponseDecoder.java:167          Received entire blob blobId
{noformat}


> DeleteOnCloseFileInputStream should properly handle errors when deleting the file
> ---------------------------------------------------------------------------------
>
>                 Key: OAK-7031
>                 URL: https://issues.apache.org/jira/browse/OAK-7031
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>             Fix For: 1.8, 1.7.13
>
>
> {{DeleteOnCloseFileInputStream}} uses {{File#delete}} to delete the temporary file. It
would be an improvement to use {{Files#deleteIfExists}}, which would provided more detailed
reports in case of errors.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message