jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-7225) Replace AtomicCounter Supplier
Date Thu, 22 Feb 2018 14:49:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372886#comment-16372886

Julian Reschke commented on OAK-7225:

AFAIU, this is not a public API, right?

In any case, the context was to be able to upgrade Guava, not necessarily to get rid of it.
As far as I can tell, {{Supplier}} has not been removed from Guava, so it's not even clear
we need to get rid of it...

> Replace AtomicCounter Supplier
> ------------------------------
>                 Key: OAK-7225
>                 URL: https://issues.apache.org/jira/browse/OAK-7225
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 1.4.0, 1.6.0
>            Reporter: Davide Giannella
>            Assignee: Davide Giannella
>            Priority: Major
>         Attachments: OAK-7225-0.diff
> In the [AtomicCounter|https://github.com/apache/jackrabbit-oak/blob/7a7aa1e5d4f53f5bfb410f58264c237b288f5c74/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/atomic/AtomicCounterEditorProvider.java#L121]
we use guava's Supplier which should be trivially replaced by the JDK8 [java.util.function.Supplier|https://docs.oracle.com/javase/8/docs/api/java/util/function/Supplier.html].
> In case of backports to Oak 1.4, and therefore Java7 it should be possible to workaround
the FunctionalInterface with a utility class.

This message was sent by Atlassian JIRA

View raw message