jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Created] (OAK-7231) Remove PermissionEntryCache.getNumEntries
Date Thu, 01 Feb 2018 13:15:00 GMT
angela created OAK-7231:
---------------------------

             Summary: Remove PermissionEntryCache.getNumEntries
                 Key: OAK-7231
                 URL: https://issues.apache.org/jira/browse/OAK-7231
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: core, security
            Reporter: angela
            Assignee: angela


[~stillalex], i looks to me that {{PermissionEntryCache.getNumEntries}} is redundant and the
single place where it is called could be replaced by {{PermissionStore.getNumEntries}}.

here is why: the method is only call upon {{PermissionEntryProviderImpl.init}}, which itself
is only called if the cache is still empty or if it just has been flushed.

while i don't see an immediate drawback of the method itself, it would IMO improve readability
and clarity. 

but i definitely want to wait for your review and ok in order to make sure, i don't miss something
fundamental in such a key area of the permission evaluation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message