jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-7343) Improvements to PermissionEntryProviderImpl
Date Thu, 03 May 2018 15:48:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462635#comment-16462635
] 

angela commented on OAK-7343:
-----------------------------

[~stillalex], base on your feedback I made the following changes:

- {{MountInfoProvider.getNumEntries}}: add comment explaining the shortcut max-length reached
- {{PermissionEntryProviderImpl}}: replace {{existingNames}} by a boolean flag
- {{PermissionStoreEditor.updateNumEntries}}: remove property if the cnt unexpectedly turns
negative and log error
- {{CompiledPermissionImpl}}: revert back to {{GroupPrincipals.isGroup}}
- {{PermissionConstants}}: replace tab with spaces (old constant)
- {{PermissionStoreImpl.load(String,String)}}: add break as soon as first child matches the
access controlled path as there will always be at most one.

I will commit the changes and would suggest that we create follow up issues in case we spot
additional issues/improvements.

> Improvements to PermissionEntryProviderImpl
> -------------------------------------------
>
>                 Key: OAK-7343
>                 URL: https://issues.apache.org/jira/browse/OAK-7343
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security
>            Reporter: angela
>            Assignee: angela
>            Priority: Major
>              Labels: performance
>         Attachments: OAK-7424-tests.patch, OAK-7424.patch
>
>
> Container issue to track potential improvements to {{PermissionEntryProviderImpl}} based
on discussions with [~stillalex].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message