jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Deparvu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-7469) User Group membership synchronization could skip groups the user is already part of
Date Wed, 02 May 2018 16:04:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461228#comment-16461228
] 

Alex Deparvu commented on OAK-7469:
-----------------------------------

attaching proposed patch:  [^OAK-7469.patch]. benchmarks show a dramatic improvement for the
worst case (all group info needs to be synced), which is maybe not the case at all times (unless
the group sync is forced). this also doesn't apply if dynamic group membership is enabled.

*Benchmarks*:

* trunk
{noformat}
# SyncAllExternalUsersTest         C     min     10%     50%     90%     max       N 
Oak-MemoryNS                       1  110600  110600  110600  110600  110600       1
Oak-Segment-Tar                    1  167825  167825  167825  167825  167825       1
# SyncAllUsersTest                 C     min     10%     50%     90%     max       N 
Oak-MemoryNS                       1  104743  104743  104743  104743  104743       1
Oak-Segment-Tar                    1  208043  208043  208043  208043  208043       1
# SyncExternalUsersTest            C     min     10%     50%     90%     max       N 
Oak-MemoryNS                       1       2       4      17      27      40    3708
Oak-Segment-Tar                    1       3       7      21      37      65    2784
{noformat}

* patch
{noformat}
# SyncAllExternalUsersTest         C     min     10%     50%     90%     max       N 
Oak-MemoryNS                       1   13394   13394   13692   14906   14906       5
Oak-Segment-Tar                    1   28995   28995   29693   29766   29766       3
# SyncAllUsersTest                 C     min     10%     50%     90%     max       N 
Oak-MemoryNS                       1   14680   14680   15505   16937   16937       4
Oak-Segment-Tar                    1   30496   30496   30853   31210   31210       2
# SyncExternalUsersTest            C     min     10%     50%     90%     max       N 
Oak-MemoryNS                       1       1       4      18      29      52    3565
Oak-Segment-Tar                    1       2       5      21      37      70    2801
{noformat}

{{SyncAllExternalUsersTest}} is _down to 13%_ of the trunk version, {{SyncAllUsersTest}} _down
to 16%_, weirdly enough {{SyncExternalUsersTest}} goes up a bit so I might have to dig into
it a bit more, if needed.


> User Group membership synchronization could skip groups the user is already part of 
> ------------------------------------------------------------------------------------
>
>                 Key: OAK-7469
>                 URL: https://issues.apache.org/jira/browse/OAK-7469
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: auth-external, security
>            Reporter: Alex Deparvu
>            Assignee: Alex Deparvu
>            Priority: Major
>         Attachments: OAK-7469.patch
>
>
> Currently the user group membership sync process doesn't take into account what groups
the user is already a part of, so it will update all groups information by adding the user.
we can skip this step based on group information on the user.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message