jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OAK-7512) RestoreTest.testRestoreNameJcr2 occasionally failing
Date Tue, 05 Jun 2018 09:36:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495160#comment-16495160
] 

Julian Reschke edited comment on OAK-7512 at 6/5/18 9:35 AM:
-------------------------------------------------------------

FWIW... the way Oak (and likely Jackrabbit) implement versioning across hierarchies, it's
likely to produce surprising (broken?) results. This is due to the assumption that comparing
timestamp ranges is sufficient to determine which child node version belong to which parent
node version. Even if we had a "perfect" timestamp, this wouldn't work for branches (where
the current logic might pick a child node from a non-applicable branch), or when a child note
has been restored to a previous version before checking in the parent node.

A proper implementation would need to maintain additional references, as described in <[https://greenbytes.de/tech/webdav/rfc3253.html#rfc.section.14.2]>
for WebDAV/DeltaV.

Does this merit a separate ticket?


was (Author: reschke):
FWIW... the way Oak (and likely Jackrabbit) implement versioning across hierarchies, it's
likely to produce surprising (broken?) results. This is due to the assumption that comparing
timestamp ranges is sufficient to determine which child node version belong to which parent
node version. Even if we had a "perfect" timestamp, this wouldn't work for branches (where
the current logic might pick a child node from a non-applicable branch).

A proper implementation would need to maintain additional references, as described in <https://greenbytes.de/tech/webdav/rfc3253.html#rfc.section.14.2>
for WebDAV/DeltaV.

Does this merit a separate ticket?

> RestoreTest.testRestoreNameJcr2 occasionally failing
> ----------------------------------------------------
>
>                 Key: OAK-7512
>                 URL: https://issues.apache.org/jira/browse/OAK-7512
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: jcr
>    Affects Versions: 1.6.11, 1.9.2
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>         Attachments: OAK-7512.diff
>
>
> This tests occasionally fails for me:
> {noformat}
> testRestoreNameJcr2(org.apache.jackrabbit.test.api.version.RestoreTest): restore must
restore child node version 1.0. expected:<1.[0]> but was:<1.[1]>
> {noformat}
> I *suspect* it is timing related (because it seems to happen more frequently when the
system is busy).
> Last seen on 1.6 branch.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message