jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomek Rękawek (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-7623) SegmentNodeStore - sidegrade support between TarPersistence and AzurePersistence
Date Fri, 20 Jul 2018 07:56:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550355#comment-16550355
] 

Tomek Rękawek commented on OAK-7623:
------------------------------------

Thanks [~dulceanu]!

I reviewed the branch. It looks very good, I only have a few minor suggestions:

Connection string parsing:
 - it seems that in the {{AzureParserUtils#parseAzureConfigurationFromCustomConnection}} the
order of keys is important. I think it shouldn't matter (eg. it should be possible to put
the {{Directory}} between {{AccountKey}} and {{BlobEndpoint}}),
 - the {{URI}} class should be used in {{AzureParserUtils#parseAzureConfigurationFromUri}} to
parse URIs.

Formatting:
 - please avoid changing formatting in parts of the code not related to the branch (eg. line
wrapping in {{StoreType}}) - it makes the patch bigger and the history messier,
 - similarly for the import order,
 - please remove trailing whitespaces.

Other trivial issues:
 - please don't modify the parameters in {{SEGMENT_AZURE#createFactory}},

After fixing these, please provide a patch or a github PR.

> SegmentNodeStore - sidegrade support between TarPersistence and AzurePersistence
> --------------------------------------------------------------------------------
>
>                 Key: OAK-7623
>                 URL: https://issues.apache.org/jira/browse/OAK-7623
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>          Components: segment-tar, upgrade
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Major
>              Labels: azure, migration
>             Fix For: 1.9.0, 1.10
>
>
> Azure support for segment-tar (OAK-6922) allowed us to plug another storage option for
the segment store. Since sometimes there's the need to compare how local vs remote storage
behaves, a sidegrade from local tar storage to remote azure storage must be implemented.
> This would allow us to replicate the exact repository content, changing only the underlying
storage mechanism. Analogous to OAK-7459, the Azure Segment Store connection details will
be supplied in the following format:
>  * an URI with the following format: {{az:[https://myaccount.blob.core.windows.net/container/repo]}},
where _az_ identifies the cloud provider
>  * a secret key supplied as an environment variable, i.e. _AZURE_SECRET_KEY._



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message