jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Francesco Mari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-7853) SegmentBufferWriter not flushed after OnRC
Date Mon, 22 Oct 2018 11:20:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658892#comment-16658892

Francesco Mari commented on OAK-7853:

[~mduerig], your analysis seems right to me. The patch looks correct.

> SegmentBufferWriter not flushed after OnRC
> ------------------------------------------
>                 Key: OAK-7853
>                 URL: https://issues.apache.org/jira/browse/OAK-7853
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>            Priority: Major
>             Fix For: 1.10
> I suspect there is a rare case where a {{SegmentBufferWriter}} is not flushed from the
{{SegmentBufferWriterPool}}. This would happen after OnRC when a previous writer is [disposed|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentBufferWriterPool.java#L194]
(vs. being re-used). AFAIU this currently those writers would never be flushed any more and
thus lose their transient segment when the store is shut down. This will lead to an inconsistent
store ({{SNFE}}).

This message was sent by Atlassian JIRA

View raw message