jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Deparvu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-7856) PrincipalPermissionEntries: non-accesscontrolled path must be ignored for fullyLoaded flag
Date Tue, 23 Oct 2018 13:51:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660676#comment-16660676
] 

Alex Deparvu commented on OAK-7856:
-----------------------------------

bq. if in the permission store the path-based structure was not removed upon removal of the
last entry, the result from reading from the store would be an empty entry-collection
I agree with this part. but there's still room to re-introduce the bug if the called of the
method passes in an empty set and the size of the map would still increase by one. even in
the case the cleanup didn't happen, expected size should reflect the real number of entries,
so pushing empty sets should not increase the internal counter.

> PrincipalPermissionEntries: non-accesscontrolled path must be ignored for fullyLoaded
flag
> ------------------------------------------------------------------------------------------
>
>                 Key: OAK-7856
>                 URL: https://issues.apache.org/jira/browse/OAK-7856
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, security
>            Reporter: angela
>            Assignee: angela
>            Priority: Major
>             Fix For: 1.10, 1.9.10
>
>         Attachments: OAK-7856.patch
>
>
> [~stillalex] spotted an issue with the calculation of the 'fullyLoaded' flag inside {{PrincipalPermissionEntries}}:
since lookup non-accesscontrolled paths is also remembered the fullyLoaded flag may be mistakenly
flipped to {{true}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message