jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OAK-8139) DocumentDiscoveryLiteService hasBacklog silencing must support maven version format
Date Thu, 18 Apr 2019 13:42:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821083#comment-16821083
] 

Julian Reschke edited comment on OAK-8139 at 4/18/19 1:41 PM:
--------------------------------------------------------------

Not sure. If we add *that* amount of logic we might as well parse the version string ourselves
(replace "-" by ".", then split by ".", then pass the components into the OsgiVersion constructor
after potentially handling non-ints in the first three components).

But feel free to tune (but please turn off TABs and insert proper whitespace :-).


was (Author: reschke):
Not sure. If we add *that* amount of logic we might as well parse the version string ourselves.

But feel free to tune (but please turn off TABs and insert proper whitespace :-).

> DocumentDiscoveryLiteService hasBacklog silencing must support maven version format
> -----------------------------------------------------------------------------------
>
>                 Key: OAK-8139
>                 URL: https://issues.apache.org/jira/browse/OAK-8139
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: documentmk
>            Reporter: Stefan Egli
>            Assignee: Julian Reschke
>            Priority: Minor
>              Labels: candidate_oak_1_6
>             Fix For: 1.8.13, 1.10.3, 1.14.0
>
>         Attachments: OAK-8139.diff, OAK-8139.patch2.diff
>
>
> OAK-3492 silences log warns when it encounters an 1.0 or 1.2 oak version (in the case
where there is an inactive cluster node that doesn't have lastWrittenRootRev set).
> The silencing uses osgi Version to do the version comparison, however the actual version
is stored in maven format. This breaks for eg the case where version is set to something like
1.0.10-SNAPSHOT where it expects 1.0.10.SNAPSHOT and the following exception would occur:
> {{org.apache.jackrabbit.oak.plugins.document.DocumentDiscoveryLiteService hasBacklog:
couldn't parse version 1.0.10-SNAPSHOT : java.lang.IllegalArgumentException: invalid version
"1.0.10-SNAPSHOT": non-numeric "10-SNAPSHOT"}}
> The silencing should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message