jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Deparvu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-8234) Reduce object allocation in PermissionProviderImpl for admin sessions
Date Mon, 15 Apr 2019 09:50:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817817#comment-16817817

Alex Deparvu commented on OAK-8234:

bq. Alex Deparvu, while the intended change makes a lot of sense to me, i don't particularly
like the delegatee approach with yet another redirection. in particular since it creates a
lot of changes to the PermissionProviderImpl that might result in subtle regressions. Is there
a reason for not making the distinction between administrative subjects and regular subjects
right in the AuthorizationConfigurationImpl? that would place that fundamental difference
between set of principals that are subjected to permission evaluation vs those that are not
prominently in the flow. also for administrative principals the whole Mount handling is IMO
redundant and which is not taken into account in the patch as far as i saw. wdyt?

Interesting suggestion, I had not considered this but it makes more sense to inject the admin
provider directly in the {{AuthorizationConfigurationImpl}}. I'll update the patch.

> Reduce object allocation in PermissionProviderImpl for admin sessions
> ---------------------------------------------------------------------
>                 Key: OAK-8234
>                 URL: https://issues.apache.org/jira/browse/OAK-8234
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security
>            Reporter: Alex Deparvu
>            Assignee: Alex Deparvu
>            Priority: Major
> There was already a lot of work done here to improve efficiency of admin sessions, but
we can still do better by simply not creating many of the objects needed as parameters for
the {{CompiledPermissions}} which will be ignored anyway in the case of admin sessions.
> Ex: There are a lot of immutable trees (created via {{PermissionUtil.getReadOnlyTree(tree,
immutableRoot)}}) that are not used for the evaluation.
> Thanks to [~mreutegg] for spotting this one!

This message was sent by Atlassian JIRA

View raw message