jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-8234) Reduce object allocation in PermissionProviderImpl for admin sessions
Date Mon, 15 Apr 2019 11:35:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817879#comment-16817879

angela commented on OAK-8234:

[~stillalex], one additional observation: if the distinction between administrative and non-administrative
principal set is taken care of in {{AuthorizationConfigurationImpl}} shouldn't we remove that
check then in {{PermissionProviderImpl}}? Also: isn't {{AllPermissions}} then redundant and
should be removed?

> Reduce object allocation in PermissionProviderImpl for admin sessions
> ---------------------------------------------------------------------
>                 Key: OAK-8234
>                 URL: https://issues.apache.org/jira/browse/OAK-8234
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security
>            Reporter: Alex Deparvu
>            Assignee: Alex Deparvu
>            Priority: Major
> There was already a lot of work done here to improve efficiency of admin sessions, but
we can still do better by simply not creating many of the objects needed as parameters for
the {{CompiledPermissions}} which will be ignored anyway in the case of admin sessions.
> Ex: There are a lot of immutable trees (created via {{PermissionUtil.getReadOnlyTree(tree,
immutableRoot)}}) that are not used for the evaluation.
> Thanks to [~mreutegg] for spotting this one!

This message was sent by Atlassian JIRA

View raw message