jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Deparvu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OAK-7217) check public Oak APIs for references to Guava
Date Mon, 13 May 2019 16:28:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838660#comment-16838660
] 

Alex Deparvu edited comment on OAK-7217 at 5/13/19 4:27 PM:
------------------------------------------------------------

I tried a different approach (bash script see  [^extract-guava.sh]), it wasn't obvious but
I think I was able to collect usages of Guava.

There are 2 sets attached:
* complete usage set  [^guava-global.log] 
* only public packages set  [^guava-public.log]

Format is class and import (both normal import and static imports are captured)
{noformat}
oak-security-spi/src/main/java/org/apache/jackrabbit/oak/plugins/tree/TreeUtil.java:import
com.google.common.base.Strings;
oak-security-spi/src/main/java/org/apache/jackrabbit/oak/plugins/tree/TreeUtil.java:import
static com.google.common.collect.Iterables.contains;
{noformat}

this is how I had the global usage:
{code}
grep -Rw . -e 'import\( static\)\? com.google.common' --include=\*.java | grep -v '/src/test/'
| sort
{code}

does this cover it?

[edit] just realised that this will only catch packages exported in the pom.xml, which is
not the case for {{oak-commons}} for example.




was (Author: alex.parvulescu):
I tried a different approach (bash script see  [^extract-guava.sh]), it wasn't obvious but
I think I was able to collect usages of Guava.

There are 2 sets attached:
* complete usage set  [^guava-global.log] 
* only public packages set  [^guava-public.log]

Format is class and import (both normal import and static imports are captured)
{noformat}
oak-security-spi/src/main/java/org/apache/jackrabbit/oak/plugins/tree/TreeUtil.java:import
com.google.common.base.Strings;
oak-security-spi/src/main/java/org/apache/jackrabbit/oak/plugins/tree/TreeUtil.java:import
static com.google.common.collect.Iterables.contains;
{noformat}

this is how I had the global usage:
{code}
grep -Rw . -e 'import\( static\)\? com.google.common' --include=\*.java | grep -v '/src/test/'
| sort
{code}


does this cover it?




> check public Oak APIs for references to Guava
> ---------------------------------------------
>
>                 Key: OAK-7217
>                 URL: https://issues.apache.org/jira/browse/OAK-7217
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>            Reporter: Julian Reschke
>            Priority: Minor
>         Attachments: detect-api.diff, extract-guava.sh, guava-global.log, guava-public.log
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message