jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Deparvu (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (OAK-8249) NodeImpl#isNodeType could load mixin info lazily
Date Thu, 02 May 2019 11:51:00 GMT

     [ https://issues.apache.org/jira/browse/OAK-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Alex Deparvu resolved OAK-8249.
       Resolution: Fixed
    Fix Version/s: 1.12.1

Had a review with [~mreutegg] and we finally decided to not continue with the v2 version due
to risk of change to the {{EffectiveNodeTypeProvider#isNodeType}} method.
The current implementation is subtly different than {{Node#isNodeType}} in the case when the
session doesn't have access to the {{jcr:mixinTypes}} property and changing it would introduce
a possible regression for all callers (internal and external).
I also updated the patch with a javadoc note to {{EffectiveNodeTypeProvider}} mentioning this
difference in implementations.

Re. callers of the api, we decided it will be a good (and probably interesting) exercise to
review all calls of this method from other oak bundles as there seem to be a few of them around.

Thanks [~mreutegg] for the help.
Fixed with http://svn.apache.org/viewvc?rev=1858530&view=rev

> NodeImpl#isNodeType could load mixin info lazily
> ------------------------------------------------
>                 Key: OAK-8249
>                 URL: https://issues.apache.org/jira/browse/OAK-8249
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, core-spi, jcr
>            Reporter: Alex Deparvu
>            Assignee: Alex Deparvu
>            Priority: Minor
>             Fix For: 1.12.1
> The current isNodeType check loads both primary type and all mixins eagerly.
> I'm wondering how often is the case where someone only needs a primary type check, and
if loading the mixins lazily would improve the throughput.

This message was sent by Atlassian JIRA

View raw message