jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Francesco Mari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-8366) Add remote store monitoring for Azure
Date Mon, 03 Jun 2019 10:53:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854467#comment-16854467
] 

Francesco Mari commented on OAK-8366:
-------------------------------------

[~ierandra], the work done so far looks good to me. I would slightly simplify the implementation
by removing {{CompositeRemoteStoreMonitor}}. It's not used anywhere except in {{FileStoreBuilder}}.
I would change the semantics of {{FileStoreBuilder#withRemoteStoreMonitor}} to only accept
a single instance of {{CompositeRemoteStoreMonitor}} and let the caller decide if they want
to pass a special implementation that is the composition of many instance. Until we have that
problem, I would keep the code simple and remove {{CompositeRemoteStoreMonitor}} altogether.

> Add remote store monitoring  for Azure
> --------------------------------------
>
>                 Key: OAK-8366
>                 URL: https://issues.apache.org/jira/browse/OAK-8366
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>          Components: segment-azure
>            Reporter: Ieran Draghiciu
>            Assignee: Andrei Dulceanu
>            Priority: Major
>              Labels: TarMK
>         Attachments: azure_remote_store_monitor_1.patch
>
>
> Add remote store monitoring
> Implement the remote store monitoring for Azure Store. This should include:
> - request_count : number of request to azure store
> - error_count : number of failed requests to azure store
> - duration : duration of a request to azure store in nanoseconds 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message