jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Reutegger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-8449) LastRev check/fix in DocumentNodeStore MBean
Date Mon, 08 Jul 2019 13:13:01 GMT

    [ https://issues.apache.org/jira/browse/OAK-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16880325#comment-16880325
] 

Marcel Reutegger commented on OAK-8449:
---------------------------------------

Thanks, this looks very good now. I still changed a few minor things.

- Tightened the scope of the local variables {{sum}} and {{dryRun}} in the recover() implementation.
Moved them further down.
- Added static imports for {{checkNotNull()}} and {{checkArgument()}}. This is simply to be
consistent with the existing code.
- Moved the checks up to the beginning of the method
- Slightly changed the way DocumentNodeStoreTest.lastRevisionRecovery() checks for exceptions,
using fail() after the statement, when an exception is expected.

Committed to trunk: http://svn.apache.org/r1862746

Thanks for your contribution.

> LastRev check/fix in DocumentNodeStore MBean
> --------------------------------------------
>
>                 Key: OAK-8449
>                 URL: https://issues.apache.org/jira/browse/OAK-8449
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: documentmk
>            Reporter: Vinod Holani
>            Assignee: Marcel Reutegger
>            Priority: Minor
>         Attachments: OAK-8449_1.patch, OAK-8449_2.patch
>
>
> There is existing tooling to check _lastRev consistency of documents in the DocumentStore.
Some of the tooling is limited to MongoDB because it is implemented as utility functions for
the MongoDB shell ([oak-mongo.js|https://jackrabbit.apache.org/oak/docs/oak-mongo-js/oak.html]).
The oak-run [recovery|https://github.com/apache/jackrabbit-oak/tree/trunk/oak-run#recovery-mode] command
was initially only available on MongoDB as well, but recently RDB support was added (OAK-8004).
The recovery command however has some drawbacks. It scans the entire nodes collection, which
can be a rather expensive operation and when started in read-write mode.
> This improvement is about adding _lastRev check and fix functionality to the DocumentNodeStore
MBean. The scope of the check and fix would be limited to some path(s) in order to keep the
runtime of the operation low.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message