jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Angela Schreiber (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OAK-8657) SimpleCredentialsSupport uses Guava API in exported API
Date Tue, 01 Oct 2019 07:58:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941617#comment-16941617
] 

Angela Schreiber commented on OAK-8657:
---------------------------------------

[~reschke], yes, it should be a {{Set}} instead of {{ImmutableSet}}... IMO we don't necessarily
need to tie that to OAK-7358 but maybe it's easier. i consider the risk of fixing this issue
to be really small, specially if the interface defines it to return {{Set}}. after all i would
consider this a bug in {{SimpleCredentialsSupport}}

> SimpleCredentialsSupport uses Guava API in exported API
> -------------------------------------------------------
>
>                 Key: OAK-8657
>                 URL: https://issues.apache.org/jira/browse/OAK-8657
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: security-spi
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Major
>             Fix For: 1.24.0
>
>
> {noformat}
>     @Override
>     @NotNull
>     public ImmutableSet<Class> getCredentialClasses() {
>         return ImmutableSet.<Class>of(SimpleCredentials.class);
>     }
> {noformat}
> We should fix this to use a regular `Set` (as in the implemented interface). However,
this would be an incompatible API change; we could do that in sync with OAK-7358.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message