jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (OAK-8624) oak-run: tests leak mapd temp files
Date Mon, 02 Dec 2019 15:19:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931524#comment-16931524
] 

Julian Reschke edited comment on OAK-8624 at 12/2/19 3:18 PM:
--------------------------------------------------------------

trunk: (1.18.0) [r1867061|http://svn.apache.org/r1867061]
1.10: (1.10.6) [r1867841|http://svn.apache.org/r1867841]
1.8: (1.8.18) [r1869792|http://svn.apache.org/r1869792]
1.6: [r1870709|http://svn.apache.org/r1870709]



was (Author: reschke):
trunk: (1.18.0) [r1867061|http://svn.apache.org/r1867061]
1.10: (1.10.6) [r1867841|http://svn.apache.org/r1867841]
1.8: [r1869792|http://svn.apache.org/r1869792]


> oak-run: tests leak mapd temp files
> -----------------------------------
>
>                 Key: OAK-8624
>                 URL: https://issues.apache.org/jira/browse/OAK-8624
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: run
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>              Labels: candidate_oak_1_4
>             Fix For: 1.18.0, 1.8.18, 1.10.6, 1.6.19
>
>         Attachments: OAK-8624.diff
>
>
> This is because {{MapDBMapFactory}} is backed by temporary DB, but that one is never
closed.
> Fix:
> - make it {{closeable}}
> - adapt test case and use in {{RecoveryCommand}}
> However, {{RecoveryCommand}} sets the {{MapFactory}} instance globally, and never resets
it. Thus, if the factory is indeed closed, subsequent tests will fail. So, in {{RecoveryCommand}},
restore the default factory when done.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message