jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Reutegger (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OAK-9083) Remove unnecessary (un)boxing in oak-store-document
Date Thu, 04 Jun 2020 06:51:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-9083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125592#comment-17125592
] 

Marcel Reutegger commented on OAK-9083:
---------------------------------------

Reverted the commit with http://svn.apache.org/r1878460

bq. when using implicit unboxing you might get NPEs in surprising places

This was also the main concern I had with the proposed changes. I reviewed all changes and
AFAICS all implicit unboxing is guarded with a null check.

> Remove unnecessary (un)boxing in oak-store-document
> ---------------------------------------------------
>
>                 Key: OAK-9083
>                 URL: https://issues.apache.org/jira/browse/OAK-9083
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: documentmk
>            Reporter: Lars Grefer
>            Assignee: Marcel Reutegger
>            Priority: Major
>             Fix For: 1.32.0
>
>
> The patch can be found here: https://github.com/apache/jackrabbit-oak/pull/227



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message