jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Reutegger (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OAK-9187) LockOperation always calls SessionDelegate.refresh before executing operations
Date Fri, 08 Jan 2021 15:23:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-9187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261370#comment-17261370
] 

Marcel Reutegger commented on OAK-9187:
---------------------------------------

There are integration test failures with the patch:
{noformat}
[INFO] Running org.apache.jackrabbit.oak.jcr.tck.LockIT
[ERROR] Tests run: 121, Failures: 1, Errors: 1, Skipped: 0, Time elapsed: 0.666 s <<<
FAILURE! - in org.apache.jackrabbit.oak.jcr.tck.LockIT
[ERROR] testLockTransfer(org.apache.jackrabbit.test.api.lock.LockTest)  Time elapsed: 0.012
s  <<< ERROR!
javax.jcr.lock.LockException: Not an owner of the lock /testroot/node1
	at org.apache.jackrabbit.test.api.lock.LockTest.testLockTransfer(LockTest.java:440)

[ERROR] testOpenScopedLocks(org.apache.jackrabbit.test.api.lock.LockTest)  Time elapsed: 0.006
s  <<< FAILURE!
junit.framework.AssertionFailedError
	at org.apache.jackrabbit.test.api.lock.LockTest.testOpenScopedLocks(LockTest.java:473)
{noformat}

> LockOperation always calls SessionDelegate.refresh before executing operations
> ------------------------------------------------------------------------------
>
>                 Key: OAK-9187
>                 URL: https://issues.apache.org/jira/browse/OAK-9187
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Angela Schreiber
>            Priority: Major
>         Attachments: OAK-9187.patch
>
>
> [~asanso] reported that calls to {{LockManager.isLocked}} (or {{Node.isLocked}}) always
results in the session being forcefully refreshed. This is inconsistent with other JCR level
read operations which either don't refresh at all or only refresh in the {{SessionDelegate#prePerform}}
if the {{RefreshStrategy}} in place mandates it.
> The same seems to apply for those lock-related methods that include write: The session
is always refreshed upon entering the methods, while other write operations either delegate
refresh to the {{RefreshStrategy}} or only refresh once changes have been committed to the
underlying {{Root}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message