jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Angela Schreiber (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OAK-9187) LockOperation always calls SessionDelegate.refresh before executing operations
Date Fri, 08 Jan 2021 15:37:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-9187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261375#comment-17261375
] 

Angela Schreiber commented on OAK-9187:
---------------------------------------

[~mreutegg], maybe missing explicit refresh in the tests? today the following TCK tests are
already excluded (copied from oak-jcr pom.xm):

{code}
<!-- Locking : not fully implemented -->
      org.apache.jackrabbit.test.api.lock.LockTest#testNodeLocked <!-- OAK-3482 -->
      org.apache.jackrabbit.test.api.lock.LockTest#testAddRemoveLockToken <!-- OAK-2149
-->
      org.apache.jackrabbit.test.api.lock.SetValueLockExceptionTest#testSetValueLockException
 <!-- OAK-2149 -->
      org.apache.jackrabbit.test.api.lock.DeepLockTest#testRemoveLockedChild <!-- OAK-2149
-->
      org.apache.jackrabbit.test.api.lock.LockManagerTest#testRemoveLockToken3 <!-- OAK-2149
-->
      org.apache.jackrabbit.test.api.lock.SessionScopedLockTest#testImplicitUnlock
      org.apache.jackrabbit.test.api.lock.SessionScopedLockTest#testImplicitUnlock2
{code}

maybe just add 2 more?

> LockOperation always calls SessionDelegate.refresh before executing operations
> ------------------------------------------------------------------------------
>
>                 Key: OAK-9187
>                 URL: https://issues.apache.org/jira/browse/OAK-9187
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Angela Schreiber
>            Priority: Major
>         Attachments: OAK-9187.patch
>
>
> [~asanso] reported that calls to {{LockManager.isLocked}} (or {{Node.isLocked}}) always
results in the session being forcefully refreshed. This is inconsistent with other JCR level
read operations which either don't refresh at all or only refresh in the {{SessionDelegate#prePerform}}
if the {{RefreshStrategy}} in place mandates it.
> The same seems to apply for those lock-related methods that include write: The session
is always refreshed upon entering the methods, while other write operations either delegate
refresh to the {{RefreshStrategy}} or only refresh once changes have been committed to the
underlying {{Root}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message