jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Angela Schreiber (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OAK-9246) Avoid hardcoding stats classes in SecurityProviderRegistration
Date Thu, 07 Jan 2021 12:18:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-9246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260466#comment-17260466

Angela Schreiber commented on OAK-9246:

[~mreutegg], thanks for the thoughts (i didn't see before committing the patch). yes, if i
remember correcttly bumps were necessary because of the new method on 'SecurityConfiguration'
interface (despite the fact that there is a default method implementation).

> Avoid hardcoding stats classes in SecurityProviderRegistration
> --------------------------------------------------------------
>                 Key: OAK-9246
>                 URL: https://issues.apache.org/jira/browse/OAK-9246
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security, security-spi
>            Reporter: Angela Schreiber
>            Assignee: Angela Schreiber
>            Priority: Major
>             Fix For: 1.38.0
>         Attachments: OAK-9246.patch
> OAK-8102 introduce a single {{LoginModuleStats}} to collect unexpected errors during
the repository login. the corresponding monitor and mbeans are registered in the {{SecurityProviderRegistration}}
after creating the {{SecurityProvider}} instance.
> instead of 'hardcoding' the stats in {{SecurityProviderRegistration}}, i would suggest
to come up with a mechanism that allows individual security modules to register statistics
related monitors and mbeans as needed. 

This message was sent by Atlassian Jira

View raw message