jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Angela Schreiber (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OAK-9246) Avoid hardcoding stats classes in SecurityProviderRegistration
Date Fri, 08 Jan 2021 09:13:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-9246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261149#comment-17261149
] 

Angela Schreiber commented on OAK-9246:
---------------------------------------

Committed revision 1885265: fixed mockito errors with java8 in {{LoginModuleMonitorTest}}
and typo in javadoc of  {{LoginModuleMonitor}}

> Avoid hardcoding stats classes in SecurityProviderRegistration
> --------------------------------------------------------------
>
>                 Key: OAK-9246
>                 URL: https://issues.apache.org/jira/browse/OAK-9246
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security, security-spi
>            Reporter: Angela Schreiber
>            Assignee: Angela Schreiber
>            Priority: Major
>             Fix For: 1.38.0
>
>         Attachments: OAK-9246.patch
>
>
> OAK-8102 introduce a single {{LoginModuleStats}} to collect unexpected errors during
the repository login. the corresponding monitor and mbeans are registered in the {{SecurityProviderRegistration}}
after creating the {{SecurityProvider}} instance.
> instead of 'hardcoding' the stats in {{SecurityProviderRegistration}}, i would suggest
to come up with a mechanism that allows individual security modules to register statistics
related monitors and mbeans as needed. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message