jakarta-bcel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yudhi Widyatama <y_widyat...@yahoo.com>
Subject loop limiter in BCELifier.printFlags
Date Wed, 12 Apr 2006 11:01:37 GMT
Hi,
I'm wondering about the line 195 in
org/apache/bcel/util/BCELifier.java (trunk code in
SVN):
         for (int i = 0, pow = 1; i <=
Constants.MAX_ACC_FLAG; i++) {
...
            pow <<= 1;
        }
If I understand this correctly, there is no need to do
the loop 0x4000 times (which is the value of
Constants.MAX_ACC_FLAG). I thought it would be better
like this:
        for (int i = 0, pow = 1; i <
Constants.ACCESS_NAMES.length; i++) {
Pardon me if I'm wrong.
Regards,

Yudhi Widyatama


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

---------------------------------------------------------------------
To unsubscribe, e-mail: bcel-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bcel-dev-help@jakarta.apache.org


Mime
View raw message