jakarta-bcel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Torsten Curdt" <tcu...@apache.org>
Subject Re: loop limiter in BCELifier.printFlags
Date Sun, 16 Apr 2006 16:50:19 GMT
Yudhi,

Well spotted! ..but I think your fix is not correct.
I think it should just be

  for (int i = 0, pow = 1; pow <= Constants.MAX_ACC_FLAG; i++) {
    ...
    pow <<= 1;
  }

cheers
--
Torsten

On 4/12/06, Yudhi Widyatama <y_widyatama@yahoo.com> wrote:
> Hi,
> I'm wondering about the line 195 in
> org/apache/bcel/util/BCELifier.java (trunk code in
> SVN):
>          for (int i = 0, pow = 1; i <=
> Constants.MAX_ACC_FLAG; i++) {
> ...
>             pow <<= 1;
>         }
> If I understand this correctly, there is no need to do
> the loop 0x4000 times (which is the value of
> Constants.MAX_ACC_FLAG).
> I thought it would be better
> like this:
>         for (int i = 0, pow = 1; i <
> Constants.ACCESS_NAMES.length; i++) {
> Pardon me if I'm wrong.

---------------------------------------------------------------------
To unsubscribe, e-mail: bcel-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bcel-dev-help@jakarta.apache.org


Mime
View raw message