jakarta-bsf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Igor Bukanov <i...@fastmail.fm>
Subject Re: More problems with latest BSF changes
Date Wed, 09 Jul 2003 19:24:41 GMT
Victor J. Orlikowski wrote:
> On Wed, Jul 09, 2003 at 04:50:57PM +0200, Igor Bukanov wrote:
>>>    [junit] 	at org.apache.bsf.BSFManager.exec(Unknown Source)
>>It means that org.apache.bsf.engines.javascript.JavaScriptEngine.eval 
>>calls org.mozilla.javascript.Context.evaluateString with negative value 
>>for script starting line number. Rhino does not accept it: use 1 if unknown.
> Fixed. This was part and parcel w/ the removal of the source,
> lineNo, and columnNo parameters. 
> I had thought that I could get away w/ a
> 0 or -1 line number. It has been set to 1 now.

Well, you could get away with 0, but -1 for a line number has no sence. 
But note that Rhino use the suplied line number in error messages and if 
a script comes from a middle of file, it would be hard for a user to 
locate errors. So BSF API should allow to pass this information.

Regards, Igor

View raw message