jakarta-jcs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Stevens (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCS-21) JCS has inconsistent locking of shared data
Date Sun, 18 Mar 2007 21:40:09 GMT

    [ https://issues.apache.org/jira/browse/JCS-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481975
] 

Michael Stevens commented on JCS-21:
------------------------------------

The principle I followed in the changes, which I suspect from the code you may disagree with,
is that if you're sometimes locking access to a field, you always need to.

> JCS has inconsistent locking of shared data
> -------------------------------------------
>
>                 Key: JCS-21
>                 URL: https://issues.apache.org/jira/browse/JCS-21
>             Project: JCS
>          Issue Type: Bug
>    Affects Versions: jcs-1.2.7.9.2
>            Reporter: Michael Stevens
>         Assigned To: Aaron Smuts
>         Attachments: locking.diff
>
>
> I've been looking at the trunk JCS code with findbugs (http://findbugs.sf.net/).
> One of the things it does is warn when data is inconsistently synchronized - ie when
it is sometimes referenced inside a synchronized block and sometimes not. This is not threadsafe
- one thread may read old or inconsistent data.
> I've patched all the places findbugs complains about by adding appropriate synchronized()
blocks.
> I suspect this change may require some discussion :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jcs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jcs-dev-help@jakarta.apache.org


Mime
View raw message