james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harmeet Bedi" <hb...@yahoo.com>
Subject Re: [GUMP] Build Failure - James and Lock related changes
Date Sun, 08 Apr 2001 00:30:13 GMT
Added previous version of org.apache.avalon.util.Lock to package
org.apache.avalon.james.util

The build shoud go ok now. Hopefully the duplication in Lock.java files will
get removed and exist only under Avalon. For now it gets the build going and
removes block on other work.

Harmeet
----- Original Message -----
From: "Harmeet Bedi" <hbedi@yahoo.com>
To: <james-dev@jakarta.apache.org>; <avalon-dev@jakarta.apache.org>
Sent: Saturday, April 07, 2001 3:35 PM
Subject: [GUMP] Build Failure - James and Lock related changes


> The build failure seems to be because of recent changes in the Lock
> API/Implemenation. Not sure how to fix this.
>
> I don't really know why the lock API changed. The earlier one seemed be in
> use, and a parts of James rely on it. For example see the attached mail.
>
> Also comparing the new Lock implementation from util.concurrent's Mutex, I
> realized. that if there is an InterruptedException thrown in the Lock
method
> the other waiting to acquire threads are not notified. There seems to be
one
> more problem. the attached comparison could be useful.
>
> <acquire> method of util.concurrent's Mutex.
> ----------------------------------------------------------
>   public void acquire() throws InterruptedException {
>     if (Thread.interrupted()) throw new InterruptedException();
>     synchronized(this) {
>       try {
>         while (inuse_) wait();
>         inuse_ = true;
>       }
>       catch (InterruptedException ex) {
>         notify();
>         throw ex;
>       }
>     }
>   }
> ------------------------------------------
>
> here is the comparable <lock> method from avalon.util's Lock.
> -------------------------------------
>     public final void lock()
>     throws InterruptedException
>     {
>         synchronized (this) {
>             while (this.isLocked) this.wait();
>             this.isLocked = true;
>         }
>     }
> --------------------------------------
>
> I think one should reuse a solid concurrency management library if it is
> available. I think one should consider Doug Lea's package as a reasonable
> and stable candidate. Anyway not sure how to fix the James build in a safe
> manner, hope someone knows how to.
>
> Harmeet
>
>
> ----- Original Message -----
> From: "Peter Donald" <donaldp@apache.org>
> To: <james-dev@jakarta.apache.org>
> Sent: Saturday, April 07, 2001 2:44 AM
> Subject: [GUMP] Build Failure - James
>
>
> > ----------------------------------------------------
> > This email is autogenerated from the output from:
> > <http://jakarta.apache.org/builds/gump/2001-04-07/jakarta-james.html>
> > ----------------------------------------------------
> >
> > Buildfile: build.xml
> >
> > init:
> >
> > prepare:
> >     [mkdir] Created dir: /home/rubys/jakarta/jakarta-james/build
> >
> > prepare-src:
> >     [mkdir] Created dir: /home/rubys/jakarta/jakarta-james/build/src
> >     [mkdir] Created dir: /home/rubys/jakarta/jakarta-james/build/classes
> >     [mkdir] Created dir: /home/rubys/jakarta/jakarta-james/build/lib
> >     [mkdir] Created dir: /home/rubys/jakarta/jakarta-james/build/conf
> >      [copy] Copying 1 file to
> /home/rubys/jakarta/jakarta-james/build/src/org/apache/james
> >      [copy] Copying 1 file to
/home/rubys/jakarta/jakarta-james/build/conf
> >
> > compile:
> >     [javac] Compiling 119 source files to
> /home/rubys/jakarta/jakarta-james/build/classes
> >     [javac]
>
/home/rubys/jakarta/jakarta-james/src/org/apache/james/mailrepository/Avalon
> MailRepository.java:23: Class org.apache.avalon.util.LockException not
found
> in import.
> >     [javac] import org.apache.avalon.util.LockException;
> >     [javac]        ^
> >     [javac]
>
/home/rubys/jakarta/jakarta-james/src/org/apache/james/mailrepository/TownSp
> oolRepository.java:30: Class org.apache.avalon.util.LockException not
found
> in import.
> >     [javac] import org.apache.avalon.util.LockException;
> >     [javac]        ^
> >     [javac]
>
/home/rubys/jakarta/jakarta-james/src/org/apache/james/mailrepository/Avalon
> SpoolRepository.java:41: Wrong number of arguments in method.
> >     [javac]                 if (lock.lock(s)) {
> >     [javac]                              ^
> >     [javac]
>
/home/rubys/jakarta/jakarta-james/src/org/apache/james/mailrepository/Avalon
> SpoolRepository.java:61: Wrong number of arguments in method.
> >     [javac]                 if (lock.lock(s)) {
> >     [javac]                              ^
> >     [javac]
>
/home/rubys/jakarta/jakarta-james/src/org/apache/james/smtpserver/SMTPHandle
> r.java:135: Note: The method java.lang.String readLine() in class
> java.io.DataInputStream has been deprecated.
> >     [javac]             while  (parseCommand(in.readLine())) {
> >     [javac]                                             ^
> >     [javac]
>
/home/rubys/jakarta/jakarta-james/src/org/apache/james/smtpserver/SizeLimite
> dSMTPHandler.java:148: Note: The method java.lang.String readLine() in
class
> java.io.DataInputStream has been deprecated.
> >     [javac]             while  (parseCommand(in.readLine())) {
> >     [javac]                                             ^
> >     [javac] Note: 2 files use or override a deprecated API.  Please
> consult the documentation for a better alternative in each case.
> >     [javac] 4 errors, 1 warning
> >
> > BUILD FAILED
> >
> > /home/rubys/jakarta/jakarta-james/build.xml:175: Compile failed,
messages
> should have been provided.
> >
> > Total time: 36 seconds
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: james-dev-help@jakarta.apache.org
>


----------------------------------------------------------------------------
----


> ---------------------------------------------------------------------
> To unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: james-dev-help@jakarta.apache.org


_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com


---------------------------------------------------------------------
To unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: james-dev-help@jakarta.apache.org


Mime
View raw message